JBIDE-24963-8 - add new testclasses for CDI 2.0 #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcervink
changed the title
zcervink
changed the title
zcervink
force-pushed
the
JBIDE-24963-8
branch
3 times, most recently
from
02981a7
to
5afbcb5
Compare
|
testPR |
|
testPR |
1 similar comment
|
testPR |
zcervink
force-pushed
the
JBIDE-24963-8
branch
2 times, most recently
from
742d457
to
a830f2b
Compare
odockal
requested changes
Jul 29, 2019
...jboss/tools/cdi/bot/test/beans/interceptor/cdi20/InterceptorValidationQuickFixTestCDI20.java
Outdated
Show resolved
Hide resolved
...org/jboss/tools/cdi/bot/test/beans/qualifier/cdi20/QualifierValidationQuickFixTestCDI20.java
Outdated
Show resolved
Hide resolved
|
@zcervink It is interesting how is it possible that jenkins build passes but validation provider is supposed to use wrong JSR definition. What is the actual problem's message assert? |
zcervink
force-pushed
the
JBIDE-24963-8
branch
6 times, most recently
from
1346ccb
to
727d199
Compare
zcervink
force-pushed
the
JBIDE-24963-8
branch
2 times, most recently
from
d6ddc64
to
d3ba6a3
Compare
|
testPR |
zcervink
force-pushed
the
JBIDE-24963-8
branch
4 times, most recently
from
be67a5a
to
d8baa9a
Compare
|
@zcervink Testss has passed on jenkins? |
odockal
approved these changes
Aug 21, 2019
zcervink
force-pushed
the
JBIDE-24963-8
branch
from
e3a5cc2
to
fb98626
Compare
No, now I have implemented fix for the NPE, after PR JBIDE-24963-10 finishes the run I will run tests on Jenkins for this PR. |
|
testPR |
zcervink
force-pushed
the
JBIDE-24963-8
branch
19 times, most recently
from
224313e
to
ec8046c
Compare
|
@odockal after some fixes the Jenkins jobs are now green: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi20.itests/162/ |
- EjbProjectWithCDITestCDI20.class - ExcludeBeanTestCDI20.class - IBindingValidationQuickFixTestCDI20.class - InterceptorValidationQuickFixTestCDI20.class - NamedRefactoringTestCDI20.class - NullValuesInjectionTestCDI20.class - QualifierValidationQuickFixTestCDI20.class Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
zcervink
force-pushed
the
JBIDE-24963-8
branch
from
ec8046c
to
a48694f
Compare
|
Update on this PR: All code smells removed, Jenkins - all green: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi20.itests/170/ |
odockal
approved these changes
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBIDE-24963-8 - add new testclasses:
Signed-off-by: Zbynek Cervinka zcervink@redhat.com
Jenkins: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi20.itests/84/
Jira: https://issues.jboss.org/browse/JBIDE-24963
please review @odockal @jkopriva