JBIDE-24963-5 - add new testclasses for CDI 2.0 #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcervink
force-pushed
the
JBIDE-24963-5
branch
3 times, most recently
from
320d68f
to
e1003b6
Compare
odockal
requested changes
Jul 29, 2019
| import org.eclipse.reddeer.eclipse.ui.views.markers.ProblemsView.ProblemType; | ||
| import org.jboss.tools.cdi.reddeer.annotation.ValidationType; | ||
|
|
||
| public class BeansXmlUIValidationProviderCDI20 extends AbstractValidationProvider { |
There was a problem hiding this comment.
Isn't this file the exact same as for CDI11 except JSR number? Wouldn't it be easier to just have one class definition with problems definition and abstract method that would return proper JSR number in children classes?
There was a problem hiding this comment.
Fixed, now testing on Jenkins.
zcervink
force-pushed
the
JBIDE-24963-5
branch
2 times, most recently
from
974338a
to
e71e4d5
Compare
odockal
requested changes
Aug 2, 2019
| private final String jsr = "JSR-346"; | ||
|
|
||
| public BeansXmlUIValidationProviderCDI11() { | ||
| private static String jsr; |
There was a problem hiding this comment.
I would suggest not to use static here. you are assigning it in constructor.
zcervink
force-pushed
the
JBIDE-24963-5
branch
2 times, most recently
from
b8dd6c7
to
d569b51
Compare
odockal
approved these changes
Aug 6, 2019
|
@jkopriva giving +1, merge this please. |
|
@zcervink please add javadoc with author in new clasess, otherwise we can merge. |
- BeansXMLAsYouTypeValidationTestCDI20.class - BeansXMLOpenOnTestCDI20.class - BeansXMLUITestCDI20.class Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
|
testPR |
|
@zcervink thanks for contribution! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBIDE-24963-5 - add new testclasses for CDI 2.0:
Signed-off-by: Zbynek Cervinka zcervink@redhat.com
Jenkins: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi20.itests/98/
Jira: https://issues.jboss.org/browse/JBIDE-24963