Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-26758 - examples.wildfly.itests contains errors like "There is no project with name ..." #1965

Merged
merged 1 commit into from Sep 16, 2019

Conversation

zcervink
Copy link
Contributor

@zcervink zcervink commented Sep 6, 2019

JBIDE-26758 - examples.wildfly.itests contains errors like "There is no project with name " for following projects:

  • dist
  • wicket-ear
  • helloworld-classfiletransformer

Jenkins: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/examples.wildfly.it.weekly/592/
Jira: https://issues.jboss.org/browse/JBIDE-26758

please review @odockal @jkopriva

Signed-off-by: Zbynek Cervinka zcervink@redhat.com

@zcervink
Copy link
Contributor Author

testPR

@zcervink
Copy link
Contributor Author

@odockal @jkopriva - update on this PR, PR check has failed, so I have rerun it, now it is SUCCESS.

@jkopriva
Copy link
Member

Source code looks good, in future version you can create some property file, so you do not need to change source code every wildfly release. You should also update wildfly-blacklist-test-errors-regexes.json.

@jkopriva jkopriva self-requested a review September 11, 2019 05:35
@zcervink zcervink force-pushed the JBIDE-26758 branch 3 times, most recently from 18115b1 to 6024279 Compare September 13, 2019 17:26
…no project with name " for following projects:

 - dist
 - wicket-ear
 - helloworld-classfiletransformer

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
@zcervink
Copy link
Contributor Author

@odockal @jkopriva Update on this issue - wildfly-blacklist-test-errors-regexes.json updated, now the only issue left is https://issues.jboss.org/browse/JBIDE-26787

Jenkins: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/examples.wildfly.it.weekly/592/

@jkopriva
Copy link
Member

@zcervink please create JIRA for investigating ".Checkstyle execution failed due to an internal error. Please check the error log for details.", this seems suspicious(could be issue with quickstarts/checkstyle plugin.). Otherwise LGTM.

@zcervink
Copy link
Contributor Author

@jkopriva
Copy link
Member

@zcervink thx! Merging.

@jkopriva jkopriva merged commit c6aac79 into jbosstools:master Sep 16, 2019
@zcervink zcervink deleted the JBIDE-26758 branch September 16, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants