Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-26991 - Update cdi.itests class and method names to contain the "CDI12" string instead of containing the "CDI11" string #1971

Merged
merged 1 commit into from Jan 10, 2020

Conversation

zcervink
Copy link
Contributor

@zcervink zcervink commented Jan 5, 2020

JIRA: https://issues.redhat.com/browse/JBIDE-26991

JENKINS CDI 1.0: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi10.itests/618/
JENKINS CDI 1.2: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi12.itests/724/
JENKINS CDI 2.0: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi20.itests/397/

Signed-off-by: Zbynek Cervinka zcervink@redhat.com

Please review @jkopriva @odockal

@zcervink zcervink force-pushed the JBIDE-26991 branch 3 times, most recently from 043ca1d to f31b731 Compare January 6, 2020 15:46
… "CDI12" string instead of containing the "CDI11" string

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
@zcervink zcervink changed the title JBIDE-26991 - Update cdi.itests class and method names to contain the "CDI12" string instead of containing the "CDI11" string [JBIDE-26991 - Update cdi.itests class and method names to contain the "CDI12" string instead of containing the "CDI11" string Jan 6, 2020
@zcervink zcervink changed the title [JBIDE-26991 - Update cdi.itests class and method names to contain the "CDI12" string instead of containing the "CDI11" string [WIP-sonar issues] JBIDE-26991 - Update cdi.itests class and method names to contain the "CDI12" string instead of containing the "CDI11" string Jan 6, 2020
@zcervink zcervink changed the title [WIP-sonar issues] JBIDE-26991 - Update cdi.itests class and method names to contain the "CDI12" string instead of containing the "CDI11" string JBIDE-26991 - Update cdi.itests class and method names to contain the "CDI12" string instead of containing the "CDI11" string Jan 6, 2020
@zcervink
Copy link
Contributor Author

zcervink commented Jan 7, 2020

@odockal
Copy link
Member

odockal commented Jan 10, 2020

@zcervink Seems ok. I will merge this right now. But I have a another task. I noticed that weld module used references older CDI specs. (1.0 and 1.1). I think it would be great to add another weld versions and use them in testing different CDI versions. I would use this WF -> Weld/CDI specs reference table. Then I would use WF version/CDI version number to differentiate between weld implementations used. Let's create another jira for this.

@odockal odockal merged commit d43d079 into jbosstools:master Jan 10, 2020
@zcervink zcervink deleted the JBIDE-26991 branch January 10, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants