JBIDE-15518 Add to CDI model extensions provided without extension service #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| IJavaProject javaProject = EclipseResourceUtil.getJavaProject(project.getProject()); | ||
| Set<String> recognizedRuntimes = CDIExtensionFactory.getInstance().getRecognizedRuntimes(javaProject); | ||
| boolean nrd = project.getExtensionManager().setRuntimes("_recognized_", recognizedRuntimes); |
There was a problem hiding this comment.
Let's move "recognized" to final static variable
…rvice Added an optional attribute "recognizer" to extension point org.jboss.tools.cdi.core.cdiextensions that holds qualified name of implementation of IExtensionRecognizer that determines if Java project containes CDI extensions that are not supposed to be registered in META-INF/services/javax.enterprise.inject.spi.Extension. Tests are added: 1. Check that extension is recognized. 2. Check that bean created by test extension implementation is available for injection. 3. Check that if dependent project has the same extension as parent project, exactly one bean is available for injection (this should be tested for each extension implementation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional attribute "recognizer" to extension point
org.jboss.tools.cdi.core.cdiextensions that holds qualified name
of implementation of IExtensionRecognizer that determines if
Java project containes CDI extensions that are not supposed to be
registered in META-INF/services/javax.enterprise.inject.spi.Extension.
Tests are added:
is available for injection.
parent project, exactly one bean is available for injection (this
should be tested for each extension implementation).