Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-18350: Loader constraint violation while generating Seam entities #257

Merged

Conversation

koentsje
Copy link
Member

No description provided.

@fbricon
Copy link
Member

fbricon commented Sep 23, 2014

+1 to apply

@koentsje
Copy link
Member Author

@dazarov @alexeykazakov I have tried to build/test these changes but the test suite failed running "org.jboss.tools.cdi.core.test" on OSX and "org.jboss.tools.jsf.text.ext.test" on Fedora20. Is there anything particular that needs to be done to build jbosstools-javaee?

@alexeykazakov
Copy link
Contributor

@koentsje those tests shouldn't be affected by your changes in hibernate/seam. So it's something not related to this PR. Only Seam component depends on hibernate. But we will take a look at these tests anyway. Thank you for reporting.

@alexeykazakov
Copy link
Contributor

Seam does not compile with this PR in 4.2.x (I have updated/re-built hibernate).
Works fine in master.

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3:00.413s
[INFO] Finished at: Tue Sep 23 13:50:10 PDT 2014
[INFO] Final Memory: 142M/752M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.21.0:compile (default-compile) on project org.jboss.tools.seam.ui: Compilation failure: Compilation failure:
[ERROR] /home/igels/Projects/jbt-4.0/contribution/jbosstools-javaee/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/views/DBTableFilterView.java:[23]
[ERROR] import org.hibernate.mapping.Table;
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Access restriction: The type 'Table' is not API (restriction on classpath entry '/home/igels/Projects/jbt-4.0/contribution-branch/.repository/.cache/tycho/org.jboss.tools.hibernate3_5-4.0.0-SNAPSHOT.jar/lib/hibernate3.jar')
[ERROR] /home/igels/Projects/jbt-4.0/contribution/jbosstools-javaee/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/views/DBTableFilterView.java:[24]
[ERROR] import org.hibernate.util.StringHelper;
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Access restriction: The type 'StringHelper' is not API (restriction on classpath entry '/home/igels/Projects/jbt-4.0/contribution-branch/.repository/.cache/tycho/org.jboss.tools.hibernate3_5-4.0.0-SNAPSHOT.jar/lib/hibernate3.jar')
[ERROR] /home/igels/Projects/jbt-4.0/contribution/jbosstools-javaee/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/views/DBTableFilterView.java:[69]
...

@koentsje
Copy link
Member Author

@alexeykazakov Can you please try again? The relevant PR for hibernate had not yet been merged when you tried this.

@alexeykazakov alexeykazakov merged commit c157764 into jbosstools:jbosstools-4.2.x Sep 24, 2014
@alexeykazakov
Copy link
Contributor

Works fine now. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants