JBIDE-19993 Add possibility to browse for "ref" elements in Design and Diagram tabs #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </action> | ||
| <action-handler> | ||
| <action>Sapphire.Jump</action> | ||
| <impl>org.jboss.tools.batch.ui.editor.internal.action.OpenOrCreateArtifactActionHandler</impl> |
There was a problem hiding this comment.
is it intentional all these are removed ?
There was a problem hiding this comment.
Yes, it is. It is impossible to explain looking at diff, because in some cases like this it completely confuses. What I did is that I declared a separate definition
<property-editor>
<id>RefPropertyEditor</id>
etc.
<property>Ref</property>
</property-editor>
which includes previous features (content assist and jump action) and new feature (browse action), and then used it in 16 places as
<include>RefPropertyEditor</include>
That reduced file by about 200 lines instead of increasing it by about 150 lines.
|
Rebased and pushed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.