JBIDE-14837 convert seam to use stacks for downloadRuntimes #90
Conversation
| @@ -35,7 +35,6 @@ Require-Bundle: org.eclipse.ui;bundle-version="3.7.0", | |||
| org.eclipse.jst.j2ee.core;bundle-version="1.2.100", | |||
| org.eclipse.jst.common.frameworks;bundle-version="1.1.500", | |||
| org.jboss.tools.jst.web.kb;visibility:=reexport, | |||
| org.jboss.tools.jsf, | |||
There was a problem hiding this comment.
This is a debatable and un-required change, but, it saved me from having to import more plugins, and, javaee still built fine locally after doing this, so IMO it was an unnecessary dependency.
But I'd be willing to revert this line if asked.
There was a problem hiding this comment.
There is no hard dependency on JBT JSF plugins in the code but Seam tools depends on Eclipse JSF Tools and it's important that JBT JSF is installed too. It extends Eclipse JSF Tools and fix some problems. I would not remove this dependency for JBT 4.0. Maybe latter we can return to this issue.
There was a problem hiding this comment.
Ok I'll fix the patch.
It would seem that you guys should be using feature requirements then instead of plugin dependencies.
There was a problem hiding this comment.
The seam feature does require o.j.t.jsf.feature. And maybe it's enough but I would not to remove this dependency for 4.0 anyway. Just not to break something when we so close to the final release.
|
I squashed the PRs and pushed them to master. |
No description provided.