Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.jboss.org/browse/JBIDE-12948 -- Do not call layout() #13

Closed
wants to merge 1 commit into from

Conversation

dmaliarevich
Copy link
Contributor

https://issues.jboss.org/browse/JBIDE-12948 -- Do not call layout() for SelectionBar if the visibilty has not been changed.

…or SelectionBar if the visibilty has not been changed.
@alexeykazakov
Copy link
Contributor

if (realBarIsVisible) {
       splitter.setVisible(realBar, true);
       splitter.setVisible(emptyBar, false);
} else {
       splitter.setVisible(realBar, false);
       splitter.setVisible(emptyBar, true);
}

would look better w/o if:

splitter.setVisible(realBar, realBarIsVisible);
splitter.setVisible(emptyBar, !realBarIsVisible);

But it's not critical of course. In general the patch looks ok.

@alexeykazakov
Copy link
Contributor

Asked Yahor to review this PR.

@alexeykazakov
Copy link
Contributor

Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants