JBIDE-17849 CSS Hyperlinks aren't working on non-WTP projects #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.w3c.dom.NodeList; | ||
|
|
||
| /** | ||
| * Copied from org.eclipse.wst.html.core.internal.htmlcss.URLModelProvider |
There was a problem hiding this comment.
If this is a modified(?) copy of some Eclipse/WTP class we should not use the standard JBoss copyright. Please see examples of such modified classes in any xpl packages.
There was a problem hiding this comment.
Yes, it's modified a bit, but probably you're right. The most of the class is a copy of URLModelProvider. The only one method (resolveURI()) is modified (it cannot be just overridden because it's static). So, I'll put the comment from the original class here.
CSS Files path resolution is fixed, CSS Hyperlink, Create New File Hyperlink are fixed JUnit test is added in order to test CSS Stylesheets inclusion using absolute and relative URLs Signed-off-by: vrubezhny <vrubezhny@exadel.com>
|
I've updated the PR |
|
Pushed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS Files path resolution is fixed, CSS Hyperlink, Create New File Hyperlink are fixed
JUnit test is added in order to test CSS Stylesheets inclusion using absolute and relative URLs
Signed-off-by: vrubezhny vrubezhny@exadel.com