JBIDE-18462 HTML5 Palette: Use text labels instead of images #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if(list != null){ | ||
| for(String word : list){ | ||
| keywords += word + " "; |
There was a problem hiding this comment.
Use StringBuilder instead.
There was a problem hiding this comment.
Done
On 10/06/2014 12:04 PM, Alexey Kazakov wrote:
In
plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/palette/model/PaletteItem.java:@@ -69,4 +72,21 @@ public boolean getReformat() {
public Tool createTool() {
return null;
}
- public String getKeywordsAsString(){
if(keywords == null){List<String> list = PaletteInsertManager.getInstance().getKeyWords(xobject.getPath());keywords = "";if(list != null){for(String word : list){keywords += word + " ";Use StringBuilder instead.
—
Reply to this email directly or view it on GitHub
https://github.com/jbosstools/jbosstools-jst/pull/398/files#r18477818.{"@context":"http://schema.org","@type":"EmailMessage","description":"View
this Pull Request on
GitHub","action":{"@type":"ViewAction","url":"https://github.com/jbosstools/jbosstools-jst/pull/398/files#r18477818","name":"View
Pull Request"}}
|
Still see old images for jQueryMobile and HTML palette. |
|
Rebased and pushed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.