Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-22446 use central.tpc.version = 4.60.0.Final-SNAPSHOT #567

Closed
wants to merge 1 commit into from

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Aug 3, 2016

JBIDE-22446 use central.tpc.version = 4.60.0.Final-SNAPSHOT -- should have made this change 4 sprints ago!

…enforcer rule passes for TP version 4.60.0.Final-SNAPSHOT; also, should have moved to 4.60.0.Final-SNAPSHOT instead of Alpha1 about 3 months ago... oops\!
@alexeykazakov
Copy link
Contributor

As you can see in the PR check above this PR doesn't solve the problem:
[ERROR] Found property angularjs.repo.url = http://download.jboss.org/jbosstools/targetplatforms/jbtearlyaccesstarget/4.60.0.Final-SNAPSHOT/REPO/

It's Final, not Alpha now but it's still a snapshot.

@nickboldt
Copy link
Member Author

Re run the PR check using the latest parent pom and it should now work.

On Aug 3, 2016 8:18 PM, "Alexey Kazakov" notifications@github.com wrote:

As you can see in the PR check above this PR doesn't solve the problem:
[ERROR] Found property angularjs.repo.url =
http://download.jboss.org/jbosstools/targetplatforms/jbtearlyaccesstarget/4.60.0.Final-SNAPSHOT/REPO/

It's Final, not Alpha now but it's still a snapshot.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#567 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN5DUPGBT-b5ZSf_H7_i_uqOnt48UPcks5qcS_ogaJpZM4JcASz
.

@alexeykazakov
Copy link
Contributor

Still failing.

@psrna
Copy link
Member

psrna commented Aug 4, 2016

testPR

@nickboldt
Copy link
Member Author

PR works when I run it locally. shrug

@nickboldt nickboldt changed the title JBIDE-22446 use central.tpc.version =... JBIDE-22446 use central.tpc.version = 4.60.0.Final-SNAPSHOT Aug 4, 2016
@psrna
Copy link
Member

psrna commented Aug 4, 2016

I've configured pr check job which runs JST Integration Tests.

@alexeykazakov
Copy link
Contributor

What is CDI11-Integration-tests check about?

@nickboldt
Copy link
Member Author

nickboldt commented Aug 4, 2016

@alexeykazakov
Copy link
Contributor

CDI11-Integration-tests is a weird name for JST tests ;)

@nickboldt
Copy link
Member Author

Yes. Curiously, the link for Details on "JST-Integration-tests" goes to the same job.

@nickboldt
Copy link
Member Author

Opened a new PR #568 but it still has the CDI11-Integration-tests notation there too. Not sure how to get rid of that for future PRs, since the jst.prcheck job now only has the "JST-Integration-tests" context.

@nickboldt nickboldt closed this Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants