JBIDE-23303 - NullPointerException in ELValidator.validateElOperand #573
Conversation
| @@ -510,7 +510,7 @@ private void validateElOperand(ELReference elReference, ELInvocationExpression o | |||
| if(token==null) { | |||
| WebKbPlugin.getDefault().logError("The token from unresolved segment is null. EL: [" + operand + "]"); | |||
| } | |||
| varName = token.getText(); | |||
| varName = token != null ? token.getText() : null; | |||
There was a problem hiding this comment.
We should probably wrap the rest of the method in } else { ...} block instead. See lines 510-512.
There was a problem hiding this comment.
Actually. I believe that adding "return;" statement in the end of "if(token==null){}" body (after the error message is logged) would be better as we don't need to worry of the rest operations in this case (and actually not able to do anything more).
There was a problem hiding this comment.
It's matter of your personal preferences. The logic will be the same. So feel free to use "return".
NPE is prevented. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
|
I've pushed an updated fix that just adds 'return;' statement after the error logging. I don't see a need of moving that amount of the rest code into any blocks as we actually cannot do anything else after token is found to be null. |
NPE is prevented.
Signed-off-by: Victor Rubezhny vrubezhny@redhat.com