Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added target folder which we should not ignore since it's used in the test project #7

Closed
wants to merge 1 commit into from

Conversation

alexeykazakov
Copy link
Contributor

No description provided.

@ghost ghost assigned dgolovin Oct 31, 2012
@maxandersen
Copy link
Member

Question: any reason this file/folder doesnt get generated when the test imports this file?

Sent from a mobile device

On 31/10/2012, at 20.55, Alexey Kazakov notifications@github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/alexeykazakov/jbosstools-jst jbide-12966
Or view, comment on, or merge it at:

#7

Commit Summary

Added target folder which we should not ignore since it's used in the…
File Changes

A tests/org.jboss.tools.jst.web.test/projects/testWebProject/target/m2e-wtp/web-resources/WEB-INF/.gitkeep (0)
Patch Links

https://github.com/jbosstools/jbosstools-jst/pull/7.patch
https://github.com/jbosstools/jbosstools-jst/pull/7.diff

Reply to this email directly or view it on GitHub.

@maxandersen
Copy link
Member

I.e. via m2 ?

Sent from a mobile device

On 31/10/2012, at 20.55, Alexey Kazakov notifications@github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/alexeykazakov/jbosstools-jst jbide-12966
Or view, comment on, or merge it at:

#7

Commit Summary

Added target folder which we should not ignore since it's used in the…
File Changes

A tests/org.jboss.tools.jst.web.test/projects/testWebProject/target/m2e-wtp/web-resources/WEB-INF/.gitkeep (0)
Patch Links

https://github.com/jbosstools/jbosstools-jst/pull/7.patch
https://github.com/jbosstools/jbosstools-jst/pull/7.diff

Reply to this email directly or view it on GitHub.

@alexeykazakov
Copy link
Contributor Author

We don't need m2 in this test at all. This JUnit tests that we do not validate derived folders. We added a derived folder 'target/WEB-INF' to the test manually to make sure it is ignored. This test was added for https://issues.jboss.org/browse/JBIDE-10161

@maxandersen
Copy link
Member

Okey cool. Just wondering :)

Sent from a mobile device

On 31/10/2012, at 21.11, Alexey Kazakov notifications@github.com wrote:

We don't need m2 in this test at all. This JUnit tests that we do not validate derived folders. We added 'target/WEB-INF' folder to the test manyally to make sure it is ignored. This test was added for https://issues.jboss.org/browse/JBIDE-10161


Reply to this email directly or view it on GitHub.

@dgolovin dgolovin closed this Nov 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants