JBIDE-14800 - livereload seem to not clean up/close listening on for jetty server on eclipse restart #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Biggest change is the JUnit test that triggers a Bundle.stop then restart it so that other tests in the suite won't fail ;-) |
| @@ -38,6 +41,10 @@ public void start(BundleContext context) throws Exception { | |||
| * @see org.eclipse.ui.plugin.AbstractUIPlugin#stop(org.osgi.framework.BundleContext) | |||
| */ | |||
| public void stop(BundleContext context) throws Exception { | |||
| // stop all servers while the plugin is stopped | |||
| for(IServer liveReloadServer : WSTUtils.findLiveReloadServers()) { | |||
| WSTUtils.stop(liveReloadServer, 30, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
can't these throw exceptions ? shouldn't it be guarded to not prevent stop ?
There was a problem hiding this comment.
and is 30 seconds really needed for jetty ?
…jetty server on eclipse restart Stopping all servers while the JBossLiveReloadCore bundle is shut down. This works for both Workbench shutdown and restart, as opposed to IWorkbenchListener which is only called when Workbench is shutdown, bot restarted
|
looks good now +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopping all servers while the JBossLiveReloadCore bundle is shut down. This works for both Workbench shutdown and restart, as opposed to IWorkbenchListener which is only called when Workbench is shutdown, bot restarted