Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Preparation for 1.1.1.Final release #35

Merged
merged 3 commits into from Oct 24, 2013
Merged

Preparation for 1.1.1.Final release #35

merged 3 commits into from Oct 24, 2013

Conversation

mickaelistria
Copy link
Contributor

No description provided.

@nickboldt
Copy link
Member

Not a big fan of the idea of single-use "touchMeForNewerTimestamp" files. Can't we just add a newline into MANIFEST.MF or pom.xml files to force jgit to see a change?

@mickaelistria
Copy link
Contributor Author

@nickboldt I don't like mich the idea of altering an important functional file just to get a new timestamp. FYI, the marker file is the pattern used by Platform (that's not a very good argument, I know)

@@ -0,0 +1 @@
Wed Oct 23 16:18:02 CEST 2013
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we adding these "editMeForNewerTimestamp" ? its not like we need them ever again.

The idea is to just do a minimal change (ie. add new line in plugin.xml or some other file that is detected by jgit timestamp plugin).

Then you can see in history why it was done - simple and effective. No need for multiple files being edited and then deleted.

@mickaelistria
Copy link
Contributor Author

@nickboldt @maxandersen I edited this commit to change the build.properties files instead of creating new files.

@maxandersen
Copy link
Member

looks much nicer and sane now ;)

Platforms approach I guess is relevant because they currently need it more often.

+1 for this.

@maxandersen
Copy link
Member

btw. I guess the version should say 1.1.1.Final not 1.1.1-SNAPSHOT?

@mickaelistria
Copy link
Contributor Author

btw. I guess the version should say 1.1.1.Final not 1.1.1-SNAPSHOT?

That will be part of another commit. I'd like to make at least a SNAPSHOT build before releasing 1.1.1.Final

@mickaelistria mickaelistria merged commit 3e85908 into jbosstools:master Oct 24, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants