Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-19024: Fixed and enhanced source artifacts mirroring. #27

Merged
merged 1 commit into from
Jan 9, 2015

Conversation

tkleszczynski
Copy link

  1. Fixed mirroring of source artifacts using Tycho 0.22.0
  2. Versions of mirrored source artifacts are the same as versions
    corresponding code artifacts.
  3. Support for mirroring feature sources.

@mickaelistria
Copy link
Contributor

I like the feature you're trying to provide, and I'd be glad to integrate it. I added inline a few questions and remarks.
On a general comment, I believe your suggested approach is very close to better support for multiple versions, instead of artifactId, we could think of using a artifactId/version couple. Using Tycho's DefaultArtifactKey class as entry for the various sets would probably be enough.

@tkleszczynski
Copy link
Author

Hi, I added support for mirroring sources for multiple versions of artifacts as you suggested.

@mickaelistria
Copy link
Contributor

that seems pretty cool! See inline a small comment about a potential typo.
Could you also please squash both your commit as a single one and use "push --force" on your branch to update this PR with a single commit? This makes review and history reading easier.

1. Fixed mirroring of source artifacts using Tycho 0.22.0
2. Versions of mirrored source artifacts are the same as versions
corresponding code artifacts.
3. Support for mirroring feature sources.
@mickaelistria
Copy link
Contributor

I merged this change that seems good to me. Note that since we (JBoss Tools) are not users of this feature that mirror sources, I've not actually tested it in real scenario.

@tkleszczynski tkleszczynski deleted the jbide-19024 branch August 12, 2015 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants