JBIDE-21701 - Enable port forwarding on a given pod and a given debug port #1015
Conversation
|
Any chance you can add some tests? |
|
@fbricon I just updated the patch with a test class to cover the methods moved into the new |
| updatePortForwardingAllowed(); | ||
| }finally { | ||
| ConsoleUtils.deregisterConsoleListener(consoleListener); | ||
| final MessageConsole console = ConsoleUtils.findMessageConsole(getMessageConsoleName()); |
There was a problem hiding this comment.
why was the try-catch block removed?
|
Can you please rebase against 4.3.x so I can merge it? |
|
@fbricon I rebase against 4.3.x and refactored a few other methods added in the mean time. |
|
Find free local ports checkbox is always disabled now http://screencast.com/t/eKBFosQt9tiQ, that's a problem |
… port Refactored the PortForwardingWizardModel to move all the port-forwarding core functionnalities in a new PortforwardingUtils class in plugins/org.jboss.tools.openshift.core. Refactored the PortForwardingWizardPage to use local variables instead of fields for the widgets.
|
@fbricon I pushed a new version of the patch that fixes this bug. Sorry about that :-/ |
| org.apache.commons.io;bundle-version="2.2.0" | ||
| org.apache.commons.io;bundle-version="2.2.0", | ||
| org.eclipse.jdt.launching;bundle-version="3.8.0", | ||
| org.eclipse.jdt.launching.macosx;bundle-version="3.3.0";resolution:=optional |
There was a problem hiding this comment.
this caused jenkins to fail
'''
[ERROR] Cannot resolve project dependencies:
[ERROR] Software being installed: org.jboss.tools.openshift.test 3.2.0.qualifier
[ERROR] Missing requirement: org.jboss.tools.openshift.test 3.2.0.qualifier requires 'bundle org.eclipse.jdt.launching.macosx 3.3.0' but it could not be found
'''
Refactored the PortForwardingWizardModel to move all the port-forwarding
core functionnalities in a new PortforwardingUtils class
in plugins/org.jboss.tools.openshift.core.
Refactored the PortForwardingWizardPage to use local variables instead
of fields for the widgets.