Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-21840 Checkbox to save password in Secure Storage is not checked when password is stored #1018

Closed
wants to merge 2 commits into from

Conversation

scabanovich
Copy link
Contributor

Two separate checkboxes are done for Basic and Auth, bound to rememberPassword and rememberToken. Checkboxes are hidden when protocol is changed.

@@ -101,6 +102,9 @@ public boolean isViewFor(Object object) {
public void onVisible(IObservableValue detailsViewModel, DataBindingContext dbc) {
bindWidgetsToInternalModel(dbc);
chkRememberToken.setText("&Save password (could trigger secure storage login)");
setCheckboxVisible(true);
chkRememberToken.getParent().update();
chkRememberToken.getParent().layout(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we have another GTK3 issue here?
Can you please comment in code so that we know in maintenance why we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two checkboxes, one should be shown the other hidden. When they are toggled this way, parent is not obliged to update layout. I think it is not GTK3, just parent need to be explicitly notified that it has to change layout.

@scabanovich scabanovich force-pushed the jbide-21840 branch 4 times, most recently from b11b6a7 to 99263b5 Compare March 14, 2016 13:58
@fbricon
Copy link
Member

fbricon commented Mar 15, 2016

Applied as dcda2f3

@fbricon fbricon closed this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants