Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-21981 - fix error during rsync #1080

Merged
merged 1 commit into from Apr 1, 2016

Conversation

robstryker
Copy link
Member

cleanup

@fbricon
Copy link
Member

fbricon commented Apr 1, 2016

Unfortunately when we ignore the rsync error, we replace the remote archive by a folder BUT, it means we need to restart the module or else none of the changes (web pages) are loaded by EAP

// quick and dirty
String profile = ServerProfileModel.getProfile(getServer());
if( "openshift3.eap".equals(profile)) {
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, return true

@fbricon
Copy link
Member

fbricon commented Apr 1, 2016

+1 to apply

cleanup

Fix issue requiring full publish if syncdown has failed

Dumb Error
@robstryker robstryker merged commit e57edcf into jbosstools:jbosstools-4.3.x Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants