JBIDDE-22150 Selected service in Properties view is not chosen in New OpenShift Server Adapter wizard #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| }; | ||
| } | ||
| } | ||
| final IServer openShiftServer = getOpenShiftServer(selectedResource); |
There was a problem hiding this comment.
I'd rather prefer you changed the getOpenShiftServer signature to take a IResource parameter instead of a IResourceUIModel
There was a problem hiding this comment.
Yes, indeed, there is no need to try to keep argument IResourceUIModel in a private method getOpenShiftServer() if we cannot provide it in a 'legal' way.
scabanovich
force-pushed
the
jbide-22150
branch
2 times, most recently
from
404776c
to
5246ced
Compare
… OpenShift Server Adapter wizard
scabanovich
force-pushed
the
jbide-22150
branch
from
5246ced
to
c4a1f83
Compare
|
Applied in master as d81763f, after fixing the current selection to look for the active part's site |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.