JBIDE-22153 Closing log of a pod throws an exception #1109
Conversation
|
@jcantrill , @fbricon , please review. |
| @@ -160,10 +160,10 @@ protected void runOCBinary(MultiStatus multiStatus) { | |||
| final MessageConsoleStream os = console.newMessageStream(); | |||
| os.setEncoding("UTF-8"); | |||
| try { | |||
| final InputStream logs = new BufferedInputStream(capability.getLogs(true, key.container, OpenShiftBinaryOption.SKIP_TLS_VERIFY)); | |||
| byte [] data = new byte [8192]; | |||
| final InputStream logs = capability.getLogs(true, key.container, OpenShiftBinaryOption.SKIP_TLS_VERIFY); | |||
There was a problem hiding this comment.
we're not buffering anything anymore?
There was a problem hiding this comment.
Stack trace shows that there is already a BufferedInputStream in the chain of streams :). Anyway, if we read into array, it is by itself a buffer. Performance is affected only when we read by one byte.
| try { | ||
| return logs.read(data); | ||
| } catch (IOException e) { | ||
| if("Stream closed".equals(e.getMessage())) { |
There was a problem hiding this comment.
Is this as exact of an exception we can get to identify a closed stream?
There was a problem hiding this comment.
This is thrown by BufferedInputStream. It would be nice to have in InputStream an interfce method isClosed() but I could not find it. The best approximation is the check (InputStream.available() < 0) but if we have BufferedInputStream, it throws that "Stream closed" in that method too instead of returning -1. So, I have decided that these too checks together may be reliable enough.
No description provided.