JBIDE-22303 Server Adapter: Manually set pod deployment path is ignored #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the unit tests for that class, to ensure we don't break that feature in the future? |
|
@scabanovich #1133 (which was merged) added a test class for the server adapter model that you can add your test to |
|
Test is added. |
| @@ -94,6 +95,17 @@ public void shouldReturnProjectThatHasGitRemoteMatchingBuildConfig() { | |||
| assertThat(project).isEqualTo(project2); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testPodPathProperty() { | |||
There was a problem hiding this comment.
did these tests really fail before your fix?
There was a problem hiding this comment.
Yes, because useInferredPodPath and podPath parameters were not assigned to class fields in update().
|
This doesn't work: http://screencast.com/t/Typn2W7b2nU |
| @@ -378,6 +380,7 @@ private void updateServer(IServerWorkingCopy server) throws OpenShiftException { | |||
| String serverName = OpenShiftServerUtils.getServerName(getService(), getConnection()); | |||
| String host = getHost(getRoute()); | |||
| String routeURL = getRouteURL(isSelectDefaultRoute(), getRoute()); | |||
| String podPath = useInferredPodPath ? this.podPath : ""; | |||
There was a problem hiding this comment.
Should be
String podPath = useInferredPodPath ? "" : this.podPath;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.