JBIDE-21422 - make server editor fields able to be edited for openshi… #1149
Conversation
| model.setInitializing(true); | ||
| try { | ||
| String conUrl = server.getAttribute(OpenShiftServerUtils.ATTR_CONNECTIONURL, (String)null); | ||
| ConnectionURL conurl2 = ConnectionURL.forURL(conUrl); |
|
Can you add some tests for the new code pretty please? |
| update(this.connection, connections, this.service, this.serviceItems); | ||
| } | ||
|
|
||
| public Connection getConnection() { | ||
| public IConnection getConnection() { |
There was a problem hiding this comment.
ServiceViewModelTest doesn't compile anymore
|
I have 2 connections to the cdk (admin/admin and openshift-dev/devel), but the connection combo doesn't select the openshift-dev one (blank instead) |
|
Also the source path input text is unusable. I recommend the browse buttons to be put to the next line, aligned right. |
|
Yes, I had mentioned in my standup that I need help with the connection not being pre-selected. UI issues on source path will be looked into. |
|
@robstryker ping me when you're on so that we can solve the connection selection issue. |
|
we discussed the issued and fixed the remaining flaw with the selection in the connection combo. I tested it quickly and it worked for me. The PR though still needs me to test it more intesively. Will do tomorrow. |
|
It seems to work, except I can't set the route settings (seen in the advanced section of the wizard) |
I'd suggest this should be an enhancement and part of a separate jira. This jira is about making existing UI editable, and once we verify it works as expected we can isolate the route stuff separately. |
|
Opened https://issues.jboss.org/browse/JBIDE-22327 to target that new issue. |
|
Fair enough, so please rebase your PR so it can be applied. |
|
+1 once rebased |
…ft server Update tests, make some utility methods private, fix bugs as per fred's comments Small ui change in layout, removed some debugging code
…ft server