JBIDE-22316 Filter template + arrow down should focus on template list and navigate through templates #1154
Conversation
|
This is pretty cool @scabanovich! Only gripe I have is when you go up, the cursor is put to the 1st position. It shouldn't. See http://screencast.com/t/Fb6w5wFU Also TabFolderTraverseListener is really a not trivial piece of code, I'd feel better if you added some unit tests for it |
scabanovich
force-pushed
the
jbide-22316
branch
2 times, most recently
from
684c5fb
to
e2f9203
Compare
|
I removed the default behaviour on arrows up/down which on MacOS apparently moved cursor, and added tests for TabFolderTraverseListener which is now a public class. |
|
well now down arrow doesn't do anything when in the filter box |
| @@ -0,0 +1,85 @@ | |||
| package org.jboss.tools.openshift.internal.ui.wizard.newapp; | |||
…t and navigate through templates 1. Children widgets of tab items are included into the list of controls traversed by tab key. 2. List is navigated with arrows while filter remains focused.
|
Ok, everything now works, except... the test fails at: The test pass when run from CLI. Must be something in my eclipse stealing the focus during tests. I suspect usage reporting. |
|
Yup usage reporting was messing the test. It's all good now. |
of controls traversed by tab key.