JBIDE-22371 Allow users easily manage environment variables of OpenShift application

[scabanovich]

No description provided.

[scabanovich]

@adietish , @fbricon , please review.

[adietish]

looks good code-wise, testing it

[adietish]

the label should be "Manage Environment Variables..." as it opens up a dialog.

[adietish]

The (preexisting - not provided by this PR) dialog to provide env vars is not following our general approach for required values. It displays an error marker if there's no value for the key:

In EnvironmentVarKeyValidator I would change #validate to the following:

        if(!(paramObject instanceof String))
            return ValidationStatus.cancel("Value is not an instance of a string");
        String value= (String) paramObject;
        if (StringUtils.isBlank(value)) {
            return ValidationStatus.cancel("Please provide a key name.");
        }

[adietish]

I also see that the wizard (not a new issue, the issue already exists) wont allow you to edit the name of a key, nor remove entries.

1. EXEC: In Explorer: pick "Manage Environment Variables" in the context menu of a service
2. EXEC: hit "Add" and provide a new key/value pair
3. EXEC: select the new key/value
4. ASSERT: "Remove" button is enabled, you can remove it
5. EXEC: "Finish" the wizard
6. EXEC: In Explorer: pick "Manage Environment Variables" in the context menu of the (same) service
7. EXEC: select the key/value pair that you just added

Result:
"Remove" button is disabled, you cannot remove it

1. EXEC: hit "Edit" (assuming that your key/value is still selected)
2. EXEC: place cursor in the variable name

Result:
You cannot change the variable name. You can change the value though

I created https://issues.jboss.org/browse/JBIDE-22429 for this.

[adietish]

superseeded by #1203