[JBIDE-22595] dont allow pw-prompt while in connection wizard #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adietish
force-pushed
the
JBIDE-22595
branch
3 times, most recently
from
f25b1d2
to
2af0ba8
Compare
|
@fbricon @jeffmaury @bdshadow review please? |
| ISelection selection = getOpenShiftExplorerSelection(); | ||
| if(selection != null) { | ||
| if(selection != null | ||
| && !selection.isEmpty()) { |
There was a problem hiding this comment.
Duplicate check. Line 180 is excess. 181-182 checks are enough
|
testPR |
bdshadow
added a commit
to bdshadow/jbosstools-openshift
that referenced
this pull request
Jun 29, 2016
…jbosstools#1236)" This reverts commit 96f6035.
bdshadow
added a commit
to bdshadow/jbosstools-openshift
that referenced
this pull request
Jul 7, 2016
…jbosstools#1236)" This reverts commit 96f6035.
bdshadow
added a commit
to bdshadow/jbosstools-openshift
that referenced
this pull request
Jul 7, 2016
…jbosstools#1236)" This reverts commit 96f6035.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS, DO NOT MERGE