JBIDE-22627 Docker image tag is ignored in Deploy Image to OpenShift wizard #1248
Conversation
| } | ||
| model.setStartedWithActiveConnection(isAuthorized); | ||
| model.initModel(connection, project, isAuthorized); | ||
|
|
||
| setNeedsProgressMonitor(true); | ||
| } | ||
|
|
||
| private String getImageNameWithTag(IDockerImage image) { |
There was a problem hiding this comment.
How does this get the tag we selected? Doesn't this just get the first sorted one, which may or may not be the one i desire? Based on the issue, it looks like we should be getting a specific tag.
There was a problem hiding this comment.
Content provider for Docker explorer for each original image creates a set of 'explorer' images based on repoTag, so that each 'explorer' image mostly has 1 tag + occasionally 'latest'. That can be seen on the screenshot to the issue. When user selects an image in Docker explorer, handler gets image object not with all tags for the repo, but most often 1. At least I see it this way. @jcantrill could you please run this PR?
There was a problem hiding this comment.
I am unable to test. My deploy menu throws exceptions that I have not been able to resolve.
|
I tested the PR and it works as advertised |
No description provided.