[JBIDE-22592] always fire change for same properties list instance #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (value != null) { | ||
| clone.setValue(value); | ||
| p.setValue(value); |
There was a problem hiding this comment.
DONT clone the parameters, set the value to the existing parameter.
| this.template = (ITemplate) source.getSource(); | ||
| updateTemplateParameters(template); | ||
| ITemplate newTemplate = (ITemplate) source.getSource(); | ||
| if (!Objects.equals(newTemplate, this.template)) { |
There was a problem hiding this comment.
dont update template parameters if we already have the very same template already set
| firePropertyChange(PROPERTY_PARAMETERS, oldParameters, this.parameters); | ||
|
|
||
| // update selected parameter | ||
| setSelectedParameter(getSelectedParameterOrDefault()); |
There was a problem hiding this comment.
update selected parameter after new parameters have been set.
|
+1 |
| public void setParameters(Collection<IParameter> parameters) { | ||
| List<IParameter> oldParameters = new ArrayList<>(this.parameters); | ||
| if (parameters == null) { | ||
| this.parameters.clear(); |
There was a problem hiding this comment.
May this.originalValueMap be cleared here, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.