[JBIDE-23210] made sure deploying docker image is using selected proj #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that is good and seems quite natural. The resource loading in model was necessary long time ago, when deploy image page had the choice for connection. As soon as a separate page for choosing connection was added, and the selector in deploy image page was replaced with info controls, there was no need any more for loading resource immediately on connection setting, it can wait until page activation. |
scabanovich
reviewed
Sep 29, 2016
|
|
||
| @Override | ||
| protected void onPageActivated(DataBindingContext dbc) { | ||
| loadResources(dbc); |
There was a problem hiding this comment.
Can it be an issue, that when deploy image page is not the first one (for instance, wizard is started from the docker explorer, and the connection page is before it), going back and forward will always cause resource loading, even if connection was not changed (though, this use case is very minor).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.