Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-23353 Deploy Docker Wizard: Enable checking "Used by route" #1357

Merged
merged 1 commit into from Oct 25, 2016

Conversation

adietish
Copy link
Member

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

checkbox by mouse click

@adietish
Copy link
Member Author

@scabanovich thanks for the initial commit!

@adietish adietish merged commit 56fe53a into jbosstools:master Oct 25, 2016
@adietish adietish deleted the JBIDE-23353 branch October 25, 2016 18:48
adietish added a commit that referenced this pull request Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants