New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-23770 - Move cdk.reddeer test-framework to jbosstools-openshift #1394

Merged

jeffmaury merged 1 commit into jbosstools:master from psrna:mv-cdk-rd

Jan 26, 2017

Member

psrna commented Jan 19, 2017

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?


          JBIDE-23770 - Move cdk.reddeer test-framework to jbosstools-openshift

f1bf83d

jeffmaury approved these changes

View reviewed changes

Member

jeffmaury left a comment

LGTM

Member Author

psrna commented Jan 23, 2017

@adietish hi Andre, can you please have a look and merge? thx!

Member Author

psrna commented Jan 26, 2017

@jeffmaury @adietish Hi guys, can you please merge? Thx!

jeffmaury merged commit 9023d42 into jbosstools:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment