[JBIDE-23821] fix NPE when existing server has no type #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robstryker +1 please? |
| @Test | ||
| public void shouldFindServerGivenListOfServersContainsServerWithNullType() throws CoreException { | ||
| // given | ||
| IServer os3Server = mockOS3Server("os3", "someService"); |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "someService" 8 times. 
There was a problem hiding this comment.
this is a test, there's no added value in defining a constant to make sure we're always using the very same string.
adietish
commented
Feb 1, 2017
| && testServer(server); | ||
| } | ||
|
|
||
| abstract protected boolean testServer(IServer server); |
There was a problem hiding this comment.
oh, a leftover of a try that I eventually stopped.
| @Test | ||
| public void shouldFindServerGivenListOfServersContainsServerWithNullType() throws CoreException { | ||
| // given | ||
| IServer os3Server = mockOS3Server("os3", "someService"); |
There was a problem hiding this comment.
this is a test, there's no added value in defining a constant to make sure we're always using the very same string.
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
|
@robstryker +1 please? |
1 similar comment
|
@robstryker +1 please? |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
General
Code
Testing
Function