Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBIDE-24025] returning null when there's no application (was: assert… #1461

Merged
merged 1 commit into from Apr 5, 2017

Conversation

adietish
Copy link
Member

@adietish adietish commented Apr 3, 2017

…ion error)

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@rhdevelopers-ci
Copy link

SonarQube analysis reported 5 issues

  1. BLOCKER ExpressServerUtils.java#L557: Close this "Repository". rule
  2. MAJOR ExpressServerUtils.java#L234: NullPointerException will be thrown when invoking method getUsername(). rule
  3. MAJOR ExpressServerUtils.java#L239: NullPointerException might be thrown as 'attributes' is nullable here rule
  4. MAJOR ExpressServerUtils.java#L241: NullPointerException might be thrown as 'attributes' is nullable here rule
  5. MAJOR ExpressServerUtils.java#L579: Extract this nested ternary operation into an independent statement. rule

@adietish adietish merged commit 73f766d into jbosstools:jbosstools-4.4.x Apr 5, 2017
adietish added a commit that referenced this pull request Apr 5, 2017
@adietish adietish deleted the JBIDE-24025 branch April 5, 2017 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants