JBIDE-24382 ensure openshift depends on min ver linuxtools.docker 2.3.0.201704251823... #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inuxtools.docker.core;bundle-version=2.3.0.201704251823 and m2e.feature 1.7.1.20161104-1805 Signed-off-by: nickboldt <nboldt@redhat.com>
|
+1 this looks safe. I'm not sure why this is needed, but I assume we're either using APIs or require functionality in these versions? Assuming there's a legitimate cause, this is a valid fix. |
|
The 2.3.0.20170425 rebuild of Docker Tools fixes wiring issues w.r.t. docker by depending on OLDER dependencies like spotify.docker 3.4, httpcomponents.httpcore (and httpclient), plus backlevels jnr.* plugins too. This is the current best solution from Neon.3 respin-b. Without this fix, installation may pull in an older version of Docker Tools, which depends on newer dependencies. This forces the old deps and the newer feature to be installed and used. |
|
@nickboldt what's the problem with the newer dependecies? |
|
Talk to Jeff Johnston, please.
…On Wed, May 3, 2017 at 4:12 PM, André Dietisheim ***@***.***> wrote:
@nickboldt <https://github.com/nickboldt> what's the problem with the
newer dependecies?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1492 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAN5DdX86uZ2ImjYwg5Zp8SSVRH-dEfEks5r2N_DgaJpZM4NP4iI>
.
--
Nick Boldt :: Productization Lead :: JBoss Tools & Dev Studio :: Red Hat,
Inc.
http://nick.divbyzero.com
|
adietish
reviewed
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBIDE-24382 ensure openshift depends on min ver linuxtools.docker 2.3.0.201704251823 and m2e.feature 1.7.1.20161104-1805
Signed-off-by: nickboldt nboldt@redhat.com
Pull Request Checklist
General
Code
Testing
Function