New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-24389 - Changed style for combos in New Connection wizard. #1495

Merged

adietish merged 1 commit into jbosstools:jbosstools-4.4.x from rhopp:JBIDE-24389-Comboboxes

May 4, 2017

Member

rhopp commented May 4, 2017

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?


          JBIDE-24389 - Changed style for combos in New Connection wizard.

3bc4040

Member Author

rhopp commented May 4, 2017

testPR

adietish approved these changes

View reviewed changes

Member

adietish commented May 4, 2017

works perfectly fine, thanks a lot!

adietish merged commit 6f48503 into jbosstools:jbosstools-4.4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment