Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbide-24322: rsync via tar strategy creates nested folders #1496

Merged
merged 1 commit into from May 8, 2017

Conversation

bdshadow
Copy link
Contributor

@bdshadow bdshadow commented May 5, 2017

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@rhdevelopers-ci
Copy link

SonarQube analysis reported 1 issue

  1. MAJOR RSync.java#L77: Remove this expression which always evaluates to "true" rule

@adietish
Copy link
Member

adietish commented May 8, 2017

+1 works for me.

@adietish adietish merged commit db24204 into jbosstools:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants