Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing of exception instead of test fail when server fails to start #1554

Merged
merged 1 commit into from Aug 31, 2017

Conversation

odockal
Copy link
Member

@odockal odockal commented Aug 29, 2017

  • added new CDKServerException class
  • moved another classes from integration test repo under cdk.reddeer plugin
    Signed-off-by: Ondrej Dockal odockal@redhat.com

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@odockal
Copy link
Member Author

odockal commented Aug 29, 2017

jbosstools/jbosstools-integration-tests#1848 depends on this PR.


@Override
protected IStatus run(IProgressMonitor monitor) {
// TODO Auto-generated method stub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO Complete the task associated to this TODO comment. rule

@rhdevelopers-ci
Copy link

SonarQube analysis reported 1 issue

  • INFO 1 info

Watch the comments in this conversation to review them.

   - added new CDKServerException class

Signed-off-by: Ondrej Dockal <odockal@redhat.com>
@bdshadow bdshadow merged commit 63b5231 into jbosstools:master Aug 31, 2017
@odockal odockal deleted the cdk-split-tests branch June 25, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants