Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBIDE-25057] always enable devmode for all servers (was: only nodejs) #1579

Merged
merged 1 commit into from
Oct 4, 2017
Merged

[JBIDE-25057] always enable devmode for all servers (was: only nodejs) #1579

merged 1 commit into from
Oct 4, 2017

Conversation

adietish
Copy link
Member

@adietish adietish commented Oct 4, 2017

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@adietish
Copy link
Member Author

adietish commented Oct 4, 2017

@jeffmaury @bdshadow please review

@adietish adietish force-pushed the JBIDE-25057 branch 4 times, most recently from fe640a4 to 79d74db Compare October 4, 2017 15:13
@adietish
[JBIDE-25057] always enable devmode for all servers (was: only nodejs)
23da63e 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
jeffmaury
jeffmaury approved these changes Oct 4, 2017
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit 3e38918 into jbosstools:master Oct 4, 2017
@adietish adietish deleted the JBIDE-25057 branch October 4, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@bdshadow bdshadow Awaiting requested review from bdshadow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adietish @jeffmaury