Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-25194 OpenShift IO Integration test #1615

Merged
merged 1 commit into from Nov 28, 2017
Merged

JBIDE-25194 OpenShift IO Integration test #1615

merged 1 commit into from Nov 28, 2017

Conversation

jkopriva
Copy link
Member

Signed-off-by: Josef Kopriva jkopriva@redhat.com

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@jkopriva
Copy link
Member Author

It will be included in StableSuite after https://issues.jboss.org/browse/JBIDE-25390 is resolved.

@jkopriva
Copy link
Member Author

testPR

adietish
adietish previously approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work for me locally

Results :

Tests run: 55, Failures: 0, Errors: 0, Skipped: 2

so once running them in jenkins slaves works we'll merge this (after master is unfrozen).

@adietish
Copy link
Member

@jkopriva openshift ITs and also cdk/openshift ITs are both unstable. Not sure including this PR or not changes anything and prevents merging. Does it?

@jkopriva
Copy link
Member Author

@adietish This test is not included in Stable suite, so it should not affect openshift.itests job on Jenkins. (I have tried it on different machines and I have experienced issues only on jenkins slaves - not sure why)

@adietish
Copy link
Member

@jkopriva can you please rebase? Once we're back in green I'd love to merge this.

@jkopriva
JBIDE-25194 OpenShift IO Integration test
fa6878e 
Signed-off-by: Josef Kopriva <jkopriva@redhat.com>
rhdevelopers-ci
rhdevelopers-ci reviewed Nov 28, 2017
View reviewed changes
...ss.tools.openshift.reddeer/src/org/jboss/tools/openshift/reddeer/utils/SystemProperties.java
@@ -27,6 +27,8 @@
public static final String KEY_USERNAME = "openshift.username";
public static final String KEY_PASSWORD = "openshift.password";
private static final String KEY_SECURE_STORAGE_PASSWORD = "securestorage.password";
public static final String KEY_OPENSHIFT_IO_USERNAME = "openshift.io.username";
public static final String KEY_OPENSHIFT_IO_PASSWORD = "openshift.io.password";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKER 'PASSWORD' detected in this expression, review this potentially hardcoded credential. rule

rhdevelopers-ci
rhdevelopers-ci reviewed Nov 28, 2017
View reviewed changes
....jboss.tools.openshift.reddeer/src/org/jboss/tools/openshift/reddeer/utils/DatastoreOS3.java
@@ -62,6 +64,10 @@
public static final String GIT_USERNAME = System.getProperty("github.username", "openshift-tools-testing-account");
public static final String GIT_PASSWORD = System.getProperty("github.password");

//OpenShift IO credentials
public static String OPENSHIFT_IO_USERNAME = System.getProperty(KEY_OPENSHIFT_IO_USERNAME);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Rename this field "OPENSHIFT_IO_USERNAME" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
MINOR Make this "public static OPENSHIFT_IO_USERNAME" field final rule
MINOR Make OPENSHIFT_IO_USERNAME a static final constant or non-public and provide accessors if needed. rule

rhdevelopers-ci
rhdevelopers-ci reviewed Nov 28, 2017
View reviewed changes
....jboss.tools.openshift.reddeer/src/org/jboss/tools/openshift/reddeer/utils/DatastoreOS3.java
@@ -62,6 +64,10 @@
public static final String GIT_USERNAME = System.getProperty("github.username", "openshift-tools-testing-account");
public static final String GIT_PASSWORD = System.getProperty("github.password");

//OpenShift IO credentials
public static String OPENSHIFT_IO_USERNAME = System.getProperty(KEY_OPENSHIFT_IO_USERNAME);
public static String OPENSHIFT_IO_PASSWORD = System.getProperty(KEY_OPENSHIFT_IO_PASSWORD);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Rename this field "OPENSHIFT_IO_PASSWORD" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
MINOR Make this "public static OPENSHIFT_IO_PASSWORD" field final rule
MINOR Make OPENSHIFT_IO_PASSWORD a static final constant or non-public and provide accessors if needed. rule

@rhdevelopers-ci
Copy link

SonarQube analysis reported 7 issues

  • BLOCKER 1 blocker
  • MINOR 6 minor

Watch the comments in this conversation to review them.

@adietish adietish merged commit 43dbd3b into jbosstools:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdevelopers-ci rhdevelopers-ci rhdevelopers-ci left review comments

@adietish adietish adietish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkopriva @adietish @rhdevelopers-ci