New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBIDE-25389] using latest openshift-restclient-java 5.9.3.Final #1620

Merged

adietish merged 1 commit into jbosstools:master from adietish:JBIDE-25389

Nov 15, 2017

Member

adietish commented Nov 15, 2017

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?


          [JBIDE-25389] using latest openshift-restclient-java 5.9.3.Final

ed995ed

Signed-off-by: Andre Dietisheim <adietish@redhat.com>

adietish force-pushed the JBIDE-25389 branch from 2318907 to ed995ed Compare

November 15, 2017 18:40

Member Author

adietish commented Nov 15, 2017

testPR

robstryker approved these changes

View reviewed changes

Member

robstryker left a comment

Seems a reasonable fix.

adietish merged commit 2405371 into jbosstools:master

adietish deleted the JBIDE-25389 branch

November 15, 2017 19:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment