JBIDE-25870 - Add CDK runtime download integration tests #1735

odockal · 2018-05-02T11:40:32Z

ITests for downloading container runtimes CDK 3.x, CDK 3.2+ and Minishift 1.14
Checking passing of credentials in download runtime wizard
Tests downloading into default folders

Signed-off-by: Ondrej Dockal odockal@redhat.com

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?

rhdevelopers-ci · 2018-05-02T12:08:33Z

...amework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/label/CDKLabel.java

@@ -61,6 +64,10 @@
 		public static final String SECURE_STORAGE = "Secure Storage";
 	}

+	public static class Links {


Add a private constructor to hide the implicit public one.

rhdevelopers-ci · 2018-05-02T12:08:33Z

...amework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/label/CDKLabel.java

@@ -95,6 +102,18 @@
 		public static final String MINISHIFT_SERVER_NAME = "Minishift 1.7+"; 
 	}

+	public static class Messages {


Add a private constructor to hide the implicit public one.

rhdevelopers-ci · 2018-05-02T12:08:34Z

...ork/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/enums/CDKRuntimeOS.java

-	LINUX("linux", ""),
-	WINDOWS("win", ".exe"),
-	MAC("darwin", ""),
+	LINUX("linux", "linux", ""), 


Define a constant instead of duplicating this literal "linux" 3 times.

rhdevelopers-ci · 2018-05-03T11:15:04Z

...ework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/enums/CDKVersion.java

+public enum CDKVersion {
+
+	CDK2X 	("CDK", "2.x", CDKLabel.Server.CDK_SERVER_NAME, ""),
+	CDK300 	("CDK", "3.0.0", CDKLabel.Server.CDK3_SERVER_NAME, "cdk-3.0-minishift-" + CDKRuntimeOS.get().getRuntimeFullName() + "-amd64" + CDKRuntimeOS.get().getSuffix()),


Define a constant instead of duplicating this literal "-amd64" 10 times.

odockal · 2018-05-03T14:03:29Z

Waiting for jenkins build to actually run a job with tests. Lot of problems recently.

rhdevelopers-ci · 2018-05-08T21:30:13Z

...amework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/label/CDKLabel.java

@@ -40,6 +42,7 @@
 		public static final String NEW_SERVER_WIZARD = "New Server";
 		public static final String WARNING_FOLDER_EXISTS = "Warning: Folder already exists!";
 		public static final String WARNING_CDK_NOT_INICIALIZED = "Warning: CDK has not been properly initialized!";
+		public static final String DOWNLOAD_RUNTIMES = "Download Runtimes";
 	}

 	public static class Labels {


Add a private constructor to hide the implicit public one.

rhdevelopers-ci · 2018-05-08T21:30:13Z

...amework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/label/CDKLabel.java

@@ -18,7 +20,7 @@
 public class CDKLabel {


Add a private constructor to hide the implicit public one.

rhdevelopers-ci · 2018-05-08T21:30:14Z

...amework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/label/CDKLabel.java

+		public static final String NOT_COMPATIBLE = "is not compatible with this server adapter";
+		public static final String SERVER_ADAPTER_REPRESENTING = "server adapter representing";
+	}
+
 	public static class Others {


Add a private constructor to hide the implicit public one.

rhdevelopers-ci · 2018-05-08T21:30:14Z

...amework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/label/CDKLabel.java

@@ -18,7 +20,7 @@
 public class CDKLabel {

 	public static class Job {


Add a private constructor to hide the implicit public one.

rhdevelopers-ci · 2018-05-08T21:30:15Z

...amework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/label/CDKLabel.java

+	public static class Links {
+		public static final String DOWNLOAD_AND_INSTALL_RUNTIME = "Download and install runtime...";
+	}
+
 	public static class Sections {


Add a private constructor to hide the implicit public one.

odockal · 2018-05-15T06:02:40Z

Rhel7 and win10 green jobs: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/devstudio_integration_tests/job/cdk.itests/590/, there are some fails on win7, though...

odockal · 2018-05-15T10:58:29Z

All green: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/devstudio_integration_tests/job/cdk.itests/592/

odockal · 2018-05-15T10:58:48Z

@jkopriva could you take a look, please?

jkopriva · 2018-05-17T09:50:53Z

...ts/org.jboss.tools.cdk.ui.bot.test/src/org/jboss/tools/cdk/ui/bot/test/CDKAllTestsSuite.java

@@ -34,10 +39,17 @@
 	// UI integration tests

 	// Wizard tests by server adapter type
-	CDK3ServerWizardTest.class,
+	/*CDK3ServerWizardTest.class,


@odockal what is the purpose of this have commented?

jkopriva · 2018-05-17T09:54:20Z

...ork/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/enums/CDKRuntimeOS.java

-	LINUX("linux", ""),
-	WINDOWS("win", ".exe"),
-	MAC("darwin", ""),
+	LINUX("linux", "linux", ""), 


@odockal maybe there could comment what these strings means...

updated in class javadoc.

rhdevelopers-ci · 2018-05-18T09:07:51Z

...ework/org.jboss.tools.cdk.reddeer/src/org/jboss/tools/cdk/reddeer/core/enums/CDKVersion.java

+	CDK320 	("CDK", "3.2.0", CDKLabel.Server.CDK32_SERVER_NAME, "cdk-3.2.0-1-minishift-" + CDKRuntimeOS.get().getRuntimeFullName() + "-amd64" + CDKRuntimeOS.get().getSuffix()),
+	CDK330 	("CDK", "3.3.0", CDKLabel.Server.CDK32_SERVER_NAME, "cdk-3.3.0-1-minishift-" + CDKRuntimeOS.get().getRuntimeFullName() + "-amd64" + CDKRuntimeOS.get().getSuffix()),
+	CDK340 	("CDK", "3.4.0", CDKLabel.Server.CDK32_SERVER_NAME, "cdk-3.4.0-2-minishift-" + CDKRuntimeOS.get().getRuntimeFullName() + "-amd64" + CDKRuntimeOS.get().getSuffix()),
+	MINISHIFT1140 ("Minishift", "1.14.0", CDKLabel.Server.MINISHIFT_SERVER_NAME, "minishift-1.14.0-" + CDKRuntimeOS.get().getRuntimeFullName() + "-amd64"),


Define a constant instead of duplicating this literal "Minishift" 4 times.

- ITests for downloading container runtimes CDK 3.x, CDK 3.2+ and Minishift 1.14, 1.15.1, 1.16.1 and 1.17.0 - Checking passing of credentials in download runtime wizard - Tests downloading into default folders Signed-off-by: Ondrej Dockal <odockal@redhat.com>

rhdevelopers-ci · 2018-05-27T14:49:41Z

SonarQube analysis reported 18 issues

3 blocker
3 critical
11 major
1 minor

Watch the comments in this conversation to review them.

8 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

CDKLabel.java#L49: 'PASSWORD' detected in this expression, review this potentially hardcoded credential.
CDKLabel.java#L90: 'PASSWORD' detected in this expression, review this potentially hardcoded credential.
CDKLabel.java#L91: 'PASSWORD' detected in this expression, review this potentially hardcoded credential.
CDKLabel.java#L27: Add a private constructor to hide the implicit public one.
CDKLabel.java#L35: Add a private constructor to hide the implicit public one.
CDKLabel.java#L77: Add a private constructor to hide the implicit public one.
CDKLabel.java#L95: Add a private constructor to hide the implicit public one.
CDKLabel.java#L31: Make this member "protected".

jkopriva · 2018-05-30T12:13:47Z

testPR

jkopriva · 2018-05-30T12:39:57Z

LGTM, merging :)

rhdevelopers-ci reviewed May 2, 2018

View reviewed changes

odockal force-pushed the runtime-download branch from a86d32e to ad15429 Compare May 3, 2018 10:11

rhdevelopers-ci reviewed May 3, 2018

View reviewed changes

odockal force-pushed the runtime-download branch 2 times, most recently from 6c384e1 to 3a01bdc Compare May 8, 2018 21:08

rhdevelopers-ci reviewed May 8, 2018

View reviewed changes

odockal force-pushed the runtime-download branch 5 times, most recently from f08a251 to 1e18a7b Compare May 10, 2018 13:12

jkopriva reviewed May 17, 2018

View reviewed changes

jkopriva self-assigned this May 17, 2018

odockal force-pushed the runtime-download branch from 1e18a7b to bfe1b3e Compare May 18, 2018 08:48

rhdevelopers-ci reviewed May 18, 2018

View reviewed changes

odockal force-pushed the runtime-download branch 2 times, most recently from 96952ca to a21b26b Compare May 23, 2018 21:59

odockal force-pushed the runtime-download branch from a21b26b to 3d6712b Compare May 27, 2018 14:24

jkopriva approved these changes May 30, 2018

View reviewed changes

jkopriva merged commit 61de110 into jbosstools:master May 30, 2018

odockal deleted the runtime-download branch June 25, 2018 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JBIDE-25870 - Add CDK runtime download integration tests #1735

JBIDE-25870 - Add CDK runtime download integration tests #1735

odockal commented May 2, 2018

rhdevelopers-ci May 2, 2018

rhdevelopers-ci May 2, 2018

rhdevelopers-ci May 2, 2018

rhdevelopers-ci May 3, 2018 •

edited

odockal commented May 3, 2018

rhdevelopers-ci May 8, 2018

rhdevelopers-ci May 8, 2018

rhdevelopers-ci May 8, 2018

rhdevelopers-ci May 8, 2018

rhdevelopers-ci May 8, 2018

odockal commented May 15, 2018

odockal commented May 15, 2018

odockal commented May 15, 2018

jkopriva May 17, 2018

jkopriva May 17, 2018

odockal May 18, 2018

rhdevelopers-ci May 18, 2018

rhdevelopers-ci commented May 27, 2018

jkopriva commented May 30, 2018

jkopriva commented May 30, 2018

		@@ -18,7 +20,7 @@
		public class CDKLabel {

		public static class Job {

JBIDE-25870 - Add CDK runtime download integration tests #1735

JBIDE-25870 - Add CDK runtime download integration tests #1735

Conversation

odockal commented May 2, 2018

Pull Request Checklist

General

Code

Testing

Function

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhdevelopers-ci May 3, 2018 • edited

Choose a reason for hiding this comment

odockal commented May 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

odockal commented May 15, 2018

odockal commented May 15, 2018

odockal commented May 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhdevelopers-ci commented May 27, 2018

8 extra issues

jkopriva commented May 30, 2018

jkopriva commented May 30, 2018

rhdevelopers-ci May 3, 2018 •

edited