Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBIDE-26173] all oc bin probs are now warnings but in server wizard #1770

Closed
wants to merge 1 commit into from
Closed

[JBIDE-26173] all oc bin probs are now warnings but in server wizard #1770

wants to merge 1 commit into from

Conversation

adietish
Copy link
Member

@adietish adietish commented Jul 9, 2018

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@adietish
[JBIDE-26173] all oc bin probs are now warnings but in server wizard
813657e 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
Copy link
Member Author

adietish commented Jul 9, 2018

@odockal please review

rhdevelopers-ci
rhdevelopers-ci reviewed Jul 9, 2018
View reviewed changes
...ui/src/org/jboss/tools/openshift/internal/ui/wizard/connection/AdvancedConnectionEditor.java
@@ -289,20 +286,16 @@ private void updateOcObservables() {
}

private void updateOcObservables(String location, boolean override) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Remove this unused method parameter "override". rule

@rhdevelopers-ci
Copy link

SonarQube analysis reported 2 issues

  • MAJOR 2 major

Watch the comments in this conversation to review them.

rhdevelopers-ci
rhdevelopers-ci reviewed Jul 9, 2018
View reviewed changes
...nshift.ui/src/org/jboss/tools/openshift/internal/ui/preferences/OpenShiftPreferencePage.java
// only disable "Apply" if we have an error, not when we have a warning
setValid(status.getSeverity() != IStatus.ERROR);
// setValid(status.getSeverity() != IStatus.ERROR);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR This block of commented-out lines of code should be removed. rule

@adietish adietish closed this Jul 11, 2018
@adietish adietish deleted the JBIDE-26173 branch July 11, 2018 10:43
@adietish
Copy link
Member Author

this will be included in a new PR for JBIDE-25700 which will include this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdevelopers-ci rhdevelopers-ci rhdevelopers-ci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adietish @rhdevelopers-ci