Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBIDE-26153] - When creating an OpenShift project, rule must be displayed first #1775

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

jeffmaury
Copy link
Member

Signed-off-by: Jeff MAURY jmaury@redhat.com

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

…layed first

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Copy link
Member

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. +1

@jeffmaury jeffmaury merged commit 40b3840 into jbosstools:master Jul 20, 2018
odockal pushed a commit to odockal/jbosstools-openshift that referenced this pull request Jul 20, 2018
…layed first (jbosstools#1775)

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants