CDK itests stabilization on jenkins #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odockal
force-pushed
the
cdk-stabilization
branch
2 times, most recently
from
4c3fefa
to
46f664b
Compare
jkopriva
reviewed
Jul 31, 2018
| @@ -233,12 +237,12 @@ protected void startServerAdapter(Runnable cond, boolean rethrow) { | |||
| protected void startServerAdapter(Server server, Runnable cond, boolean rethrow) { | |||
| log.info("Starting server adapter"); | |||
| // Workaround for CDK-216 | |||
| new WaitUntil(new NeverFulfilledCondition(), TimePeriod.getCustom(120), false); | |||
| // new WaitUntil(new NeverFulfilledCondition(), TimePeriod.getCustom(120), false); | |||
There was a problem hiding this comment.
@odockal can it be deleted? CDK-216 is closed.
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
odockal
force-pushed
the
cdk-stabilization
branch
from
46f664b
to
4699c63
Compare
jkopriva
approved these changes
Aug 2, 2018
adietish
pushed a commit
to bdshadow/jbosstools-openshift
that referenced
this pull request
Aug 9, 2018
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
adietish
pushed a commit
to bdshadow/jbosstools-openshift
that referenced
this pull request
Aug 9, 2018
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ondrej Dockal odockal@redhat.com
Pull Request Checklist
General
Code
Testing
Function