New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBIDE-28611] replace common.compress 1.18 by 1.19 #1866

Merged

adietish merged 1 commit into jbosstools:master from adietish:JBIDE-26811

Sep 5, 2019

Member

adietish commented Sep 5, 2019

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?


          [JBIDE-28611] replace common.compress 1.18 by 1.19

2f532aa

Signed-off-by: Andre Dietisheim <adietish@redhat.com>

adietish requested a review from jeffmaury

September 5, 2019 08:29

jeffmaury approved these changes

View reviewed changes

adietish merged commit 854dfa8 into jbosstools:master

adietish deleted the JBIDE-26811 branch

September 5, 2019 14:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment