Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-27589 Handling crc 1.17+ status reporting of non started machine #1967

Merged
merged 1 commit into from Jan 5, 2021
Merged

JBIDE-27589 Handling crc 1.17+ status reporting of non started machine #1967

merged 1 commit into from Jan 5, 2021

Conversation

odockal
Copy link
Member

@odockal odockal commented Dec 22, 2020

Signed-off-by: Ondrej Dockal odockal@redhat.com

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@odockal
JBIDE-27589 Handling crc 1.17+ status reporting of non started machine
8635113 
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odockal odockal requested a review from jeffmaury January 5, 2021 13:46
@jeffmaury jeffmaury merged commit 0a03aca into jbosstools:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@robstryker robstryker Awaiting requested review from robstryker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odockal @jeffmaury