New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-28499: odo 2.5.1 extraction is broken on Windows and MacOS #2079

Merged

jeffmaury merged 1 commit into jbosstools:main from jeffmaury:JBIDE-28499

Jun 1, 2022

Member

jeffmaury commented Jun 1, 2022

Signed-off-by: Jeff MAURY jmaury@redhat.com

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?


          JBIDE-28499: odo 2.5.1 extraction is broken on Windows and MacOS

40e878b

Signed-off-by: Jeff MAURY <jmaury@redhat.com>

jeffmaury requested a review from sbouchet

June 1, 2022 08:22

sbouchet approved these changes

View reviewed changes

Contributor

sbouchet left a comment

LGTM

jeffmaury merged commit 03bca5a into jbosstools:main

jeffmaury deleted the JBIDE-28499 branch

June 1, 2022 08:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment