Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor odo test suite #2109

Merged
merged 1 commit into from Mar 20, 2023
Merged

Refactor odo test suite #2109

merged 1 commit into from Mar 20, 2023

Conversation

odockal
Copy link
Member

@odockal odockal commented Mar 13, 2023

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@odockal odockal requested a review from lgrossma March 13, 2023 13:05
@odockal
Refactor odo test suite
d79b100 
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
@odockal
Copy link
Member Author

odockal commented Mar 13, 2023

@lgrossma Some test results: https://studio-jenkins-csb-codeready.apps.ocp-c1.prod.psi.redhat.com/job/Studio/job/Quality/job/Integration-tests/job/openshift-odo-itests/44/

@odockal odockal merged commit 3f41202 into jbosstools:main Mar 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrossma lgrossma lgrossma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odockal @lgrossma