[JBIDE-15847] using username reported by server, not the user provided #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -264,6 +262,11 @@ public void update(Connection connection) { | |||
| setUser(connection.getUser()); | |||
| } | |||
|
|
|||
| private String updateUsername(IUser user) { | |||
| this.username = user.getRhlogin(); | |||
There was a problem hiding this comment.
and we are 100% certain this login actually is never ever null/empty ?
And how about comparing if they are different and if they are, log an info/warning that "OpenShift connection to was allowed with , but the actual username logged in is . Will use instead of . This can sometime happens on servers, but if this is not expected report it to the admin of " ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.